Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fixes creating role when no role_arn is specified #69

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

stefanwb
Copy link
Contributor

@stefanwb stefanwb commented Mar 7, 2024

  • fix trying to create a aws_iam_role_policy when no policy is given
  • fix when role_arn is set, do not create a role in this module and create an empty role when create_policy is set to false

Signed-off-by: Stefan Wessels Beljaars [email protected]

@github-actions github-actions bot added the bug Something isn't working label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Lint 📖success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


@stefanwb stefanwb changed the title bug: Regarding creating role and policy: bug: fixes creating role when no role_arn is specified Mar 7, 2024
@stefanwb stefanwb merged commit 0a41aa7 into master Mar 8, 2024
7 checks passed
@stefanwb stefanwb deleted the fix-role-policy branch March 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants